Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 9, 2024

Describe Your Changes

  • Update the fields from
    host -> apiServerHost
    port -> apiServerPort
    Previously I mistakenly put it as host and port

Screenshot

Screenshot 2024-09-09 at 10 18 42

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@dan-menlo dan-menlo changed the title chore: update cortexrc fields chore: update .cortexrc fields Sep 9, 2024
@dan-menlo
Copy link
Contributor

@namchuai @vansangpfiev Given the amount of port number collisions at 4 digits, should we consider a standard port for Cortex that is higher rank?

  • 267839 = Cortex in T9

Outside of that: how did we choose 3928?

Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dan-menlo
Copy link
Contributor

dan-menlo commented Sep 9, 2024

@namchuai Out of curiosity, what was the issue with the initial port and host varnames?

  • I'm not sure if it's an improvement to make it more verbose
  • Given that cortex.cpp only has a single port/host now (vs. cortex platform in the original issue)

@namchuai
Copy link
Contributor Author

namchuai commented Sep 9, 2024

@namchuai Out of curiosity, what was the issue with the initial port and host varnames?

  • I'm not sure if it's an improvement to make it more verbose
  • Given that cortex.cpp only has a single port/host now (vs. cortex platform in the original issue)

One of the reason is I want to make it compatible with what user currently have. Some user already installed cortex (cortexjs) and they already have .cortexrc

@namchuai namchuai merged commit d31c7a9 into dev Sep 9, 2024
@namchuai namchuai deleted the j/update-cortexrc-fields branch September 9, 2024 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants